Weblog of Wesley Fryer

I actually do have a WordPress Installation to check out and I took a look at my copy of Akismet.php. Seems to be pretty close to yours, however I get the error on line 722. I looked into it and confirmed my understanding of what’s happening. When you have zero comments to check, the call to wpdb (which is a wrapper for ezSQL) returns false (http://justinvincent.com/docs/ezsql/ez_sql_help.htm in the demo explained section). The code doesn’t expect this, and as I said it throws an error because instead of an array of results, it gets false.

I fixed it by using a small check that is documented at that ezSQL page. essentially, change the line before the foreach to this:
if($moderation = $wpdb->get_results( “SELECT * FROM $wpdb->comments WHERE comment_approved = ’0′”, ARRAY_A )){

and then add a } before the wp_direct(… line (which I think is 747 for you). When no comments need to be reviewed, a click on the check for spam button should essentially do nothing (redirect you back to that page with no message; not the best scenario, but better than an error). If there are results, they should get processed.

Hope this helps.

Wesley, I know you said you’re running the same stuff on some other sites with no problems. Do those sites have anything in their queue? Based on what I saw in the code, I’m sticking with my theory above (same as what you saw in the second post you linked): the bug only appears when there are no items in the queue. As long as there’s something in there, you won’t see this bug.

It’s not that I think it will work only if there’s no spam, it’s that I thought that’s where the bug was. However, if you have a lot of spam in the queue then what I told you to do won’t fix anything, it will only seem that way… The implication is that the bug is somewhere else.

I thought you might have had no spam, in which case you trip a bug where a database query returns false instead of an array of data. The changes I suggested above address that false return as if the query returned no results. You are implying that the lack of results is not because there is no spam, but because the query is wrong: there is spam, however you can’t select it by querying the database for all comments that have comment_approved set to zero.

The more I think about this, the more I think we’re experiencing two different issues. I’m clicking the ‘Check For Spam’ link on the Comments page, but you’re trying to delete spam, maybe from the Akismet Spam(N) link? My wordpress install is on an intranet and I don’t get any spam there, so I don’t have any comments in the queue to test.

I thought I could help you with a quick fix, but it seems that’s not the case. I’d not make the changes I suggested in my previous comment since it appears that hides the problem without fixing it. Sorry I couldn’t be of more help here.